Refactor api keys to use TablePage component #6526
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cloudflare Pages deployment
|
viown
reviewed
Feb 15, 2025
| @@ -44,15 +47,21 @@ const TablePage = <T extends MRT_RowData>({ | |||
| height: '100%' | |||
| }} | |||
| > | |||
| <Box | |||
| <Stack | |||
| spacing={2} | |||
| sx={{ | |||
| marginBottom: 1 | |||
| }} | |||
| > | |||
| <Typography variant='h2'> | |||
There was a problem hiding this comment.
Just wondering, since we seem to be using h2 for the table pages while h1 for the other pages (branding, logs), should either be changed to match?
There was a problem hiding this comment.
I used h2 for the table pages to have more room for the table data on screen... I'm not opposed to doing the same on the other pages. 🤷♂️
|
viown
approved these changes
Feb 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Small refactor to update the API keys page to also use the new
<TablePage>component and a couple miscellaneous driveby cleanup items 🙃Issues
N/A