Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Append Box Set to TMDB external link for collections #6485

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

theguymadmax
Copy link
Contributor

Changes

Append "(Box Set)" to TheMovieDb URL when it leads to a collection.

Issues

@theguymadmax theguymadmax requested a review from a team as a code owner January 28, 2025 16:54
@jellyfin-bot
Copy link
Collaborator

jellyfin-bot commented Jan 28, 2025

Cloudflare Pages deployment

Latest commit 51c370f
Status ✅ Deployed!
Preview URL https://72540cb8.jellyfin-web.pages.dev
Type 🔀 Preview

View build logs

@thornbill
Copy link
Member

I know we discussed this on matrix, but care to rehash the specifics here about why this should be done on the client and not server... I don't recall the details and doubt I could dig that far back in element 😅 thanks!

@theguymadmax
Copy link
Contributor Author

The server distinguishes the external provider using the Type property:
• ProviderName = "TheMovieDB"
• Type = "Movie" or "Box Set"

Changing the ProviderName on the server would cause issues in places where it is used correctly, such as in the metadata editor, where the format is: ProviderName + Type + "Id"

If the ProviderName were changed on the server, it would result in other duplication:
Box Set Metdata

In the item details, we use just the ProviderName, which is why the TheMovieDB is duplicated. Adding the Type would be redundant, and it would appear for all names, leading to it being displayed as:
• TheMovieDB Movie, TheMovieDB Box Set

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants