Skip to content

Person ItemView #1606

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 26 commits into from
Jun 29, 2025
Merged

Person ItemView #1606

merged 26 commits into from
Jun 29, 2025

Conversation

JPKribs
Copy link
Member

@JPKribs JPKribs commented Jun 23, 2025

Summary

Resolves: #1590
Resolves: #1551 (Subject to change)

Creates an ItemView for people and artists. This can be used instead of the existing process where selecting a person goes to a PagingLibraryView with content from that person.

iPadOS

Screenshot 2025-06-22 at 19 53 15

Videos

From Search

Simulator.Screen.Recording.-.iPhone.16.Pro.-.2025-06-22.at.19.44.51.mp4

From Cast & Crew

Simulator.Screen.Recording.-.iPhone.16.Pro.-.2025-06-22.at.19.45.37.mp4

@JPKribs JPKribs added enhancement New feature or request iOS Specific to only iOS or iPadOS tvOS Specific to only tvOS labels Jun 23, 2025
@JPKribs JPKribs changed the title Item person view Person ItemView Jun 23, 2025
@JPKribs
Copy link
Member Author

JPKribs commented Jun 23, 2025

@LePips How would you prefer I handle this? All in 1 PR for iOS and tvOS or just iOS first then tvOS separate?

At this point, iOS & iPadOS should be ready to go. I'm leaving this as WIP in case we want to add tvOS as well in this PR.

@JPKribs JPKribs removed the tvOS Specific to only tvOS label Jun 23, 2025
Copy link
Member

@LePips LePips left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just do iOS for now. There should also be cleanup in PagingLibraryView.

@JPKribs JPKribs marked this pull request as ready for review June 23, 2025 20:02
This was referenced Jun 28, 2025
@LePips
Copy link
Member

LePips commented Jun 29, 2025

I've abstracted out the item type library fetching, which can also eventually use used for Media/Favorites. I've also accounted for some other interactions and brought over some work from my poster button cleanup.

There was one bug where the Collections would say it contained every Collection item?

On the server if the requested item type only has a single element and is the boxset type, it nullifies the parent ID. I'm unsure why this is the case, but it wouldn't hurt to investigate if the web or other clients use this behavior and get rid of this behavior, or have us find a workaround.

https://github.com/jellyfin/jellyfin/blob/630846798d8302ea5ed805ade669158b7af2f123/Jellyfin.Api/Controllers/ItemsController.cs#L274

@JPKribs
Copy link
Member Author

JPKribs commented Jun 29, 2025

it wouldn't hurt to investigate if the web or other clients use this behavior and get rid of this behavior, or have us find a workaround.

It looks like Jellyfin-Web just groups multiple items together so the call would have more than one ItemType filter in it:

https://github.com/jellyfin/jellyfin-web/blob/master/src/controllers/itemDetails/index.js#L1694C1-L1700C10

Testing, this is what this looks like:

image

@LePips LePips merged commit c537a1a into jellyfin:main Jun 29, 2025
4 checks passed
@JPKribs JPKribs deleted the itemPersonView branch June 29, 2025 16:40
@JPKribs JPKribs mentioned this pull request Jun 29, 2025
JPKribs added a commit to JPKribs/Swiftfin that referenced this pull request Jun 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request iOS Specific to only iOS or iPadOS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create PersonItemView Collection items not paginated.
2 participants