-
-
Notifications
You must be signed in to change notification settings - Fork 368
Person ItemView
#1606
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Person ItemView
#1606
Conversation
@LePips How would you prefer I handle this? All in 1 PR for iOS and tvOS or just iOS first then tvOS separate? At this point, iOS & iPadOS should be ready to go. I'm leaving this as WIP in case we want to add tvOS as well in this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just do iOS for now. There should also be cleanup in PagingLibraryView
.
Swiftfin/Views/ItemView/Components/ActionButtonHStack/ActionButtonHStack.swift
Show resolved
Hide resolved
Swiftfin/Views/ItemView/ScrollViews/iPadOSPersonScrollView.swift
Outdated
Show resolved
Hide resolved
I've abstracted out the item type library fetching, which can also eventually use used for
On the server if the requested item type only has a single element and is the boxset type, it nullifies the parent ID. I'm unsure why this is the case, but it wouldn't hurt to investigate if the web or other clients use this behavior and get rid of this behavior, or have us find a workaround. |
It looks like Jellyfin-Web just groups multiple items together so the call would have more than one Testing, this is what this looks like: |
Summary
Resolves: #1590
Resolves: #1551 (Subject to change)
Creates an
ItemView
for people and artists. This can be used instead of the existing process where selecting a person goes to aPagingLibraryView
with content from that person.iPadOS
Videos
From Search
Simulator.Screen.Recording.-.iPhone.16.Pro.-.2025-06-22.at.19.44.51.mp4
From Cast & Crew
Simulator.Screen.Recording.-.iPhone.16.Pro.-.2025-06-22.at.19.45.37.mp4