Support multiple thumbs #89
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now we can pass an array to `value` to achieve multiple thumbs. `thumbImage` accepts an array also - to override individual thumbs. There's a new `thumbView` property, that works like `thumbImage` but supplies the whole thumb View. An idea I took from @doctadre's PR, is better naming for the following props: `minimumTrackTintColor` is deprecated, use `trackHighlightColor` `maximumTrackTintColor ` is deprecated, use `trackColor`
RoshOne4
approved these changes
Jan 29, 2018
idealllee
reviewed
Feb 2, 2018
src/Slider.js
Outdated
| trackHighlightStyle = { | ||
| position: 'absolute', | ||
| left: 0, | ||
| width: Animated.add(thumbLeft, thumbSize.width / 2), |
There was a problem hiding this comment.
@danielgindi should the thumbLeft be something else given that it no longer exists?
…sappear for single thumb
fix value prop update
|
@danielgindi This feature would be great, where are we with it ? |
|
It's just waiting for a merge! |
|
@idealllee @RoshOne4 Can it be merged ? |
|
@jeanregisser can we get this merged? Awesome feature. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now we can pass an array to
valueto achieve multiple thumbs.thumbImageaccepts an array also - to override individual thumbs.There's a new
thumbViewproperty, that works likethumbImagebut supplies the whole thumb View.An idea I took from @doctadre's PR, is better naming for the following props:
minimumTrackTintColoris deprecated, usetrackHighlightColormaximumTrackTintColoris deprecated, usetrackColor