Add thumb image style prop #126
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any idea on the timeline of this fix please? |
rubypirate
approved these changes
Jan 7, 2019
|
not working |
|
@andriko007 Care to elaborate? |
|
@WoodyWoodsta tried to apply your changes but the style of the thumbImage does not change. Can't understand why? |
|
@andriko007 Difficult to tell without seeing your implementation + forked changes. I have no issue. |
|
@WoodyWoodsta I just did changes in my project. Can you explain how to install react-native-slider with your fork? Thanks. |
|
@andriko007 Plenty of answers after a short Google https://stackoverflow.com/questions/9153598/how-do-i-fetch-a-branch-on-someone-elses-fork-on-github/9153737#9153737 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #125 (comment)