-
-
Notifications
You must be signed in to change notification settings - Fork 431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: update demo #4350
base: main
Are you sure you want to change the base?
docs: update demo #4350
Conversation
@@ -0,0 +1,90 @@ | |||
# Use mise run docs:demo to record this tape | |||
|
|||
Output demo.gif |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if the demo.gif is not used you can probably removed it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I can remove it 👍
The other option I was thinking about is to leave the gif in the readme and go to the demo page if one clicks on it ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the mp4 can be paused / resume, it's a huge advantage imo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I agree. So my idea would be to have the video as .mp4
on the demo page only - while we leave the .gif
in the Readme.
The .gif
will work everywhere, while the video is not shown in some markdown renderer. If the user tries to click on the .gif
to pause it, then it will send them to the demo page where they can see the transcript + play/pause the video. I think this will also avoid having to host it through GitHub 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're right
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems to not be used
demo.mp4
https://github.com/jdx/mise/blob/7bfe613e595475b09ff83853bbebf85519e711ca/README.md