fix: Fix syntax error on activate nu
when PATH contains shims
#4349
+89
−21
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background and Purpose
When nushell has shims in the PATH,
activate nu
outputs an incorrect script.The problem is at the beginning of the script generated by
activate nu
This gives the following error in nushell 0.102.
This is not a Nu script, but a CSV protocol.
The nushell functions defined in
activate
(def “parse vars”
) parse CSV only fordeactivate
,shell
andsh
command output.The CSV protocol is not available in
activate
itself, so it must output valid Nu scripts.Changes
Shell::set_env
should change the output if it is running in the context ofactivate
. I introducedenum ActivatePrelude
to avoid making it mutable.Impact