Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test flyci #57

Closed
wants to merge 3 commits into from
Closed

test flyci #57

wants to merge 3 commits into from

Conversation

jdeniau
Copy link
Owner

@jdeniau jdeniau commented Mar 16, 2024

No description provided.

@kgantchev
Copy link

kgantchev commented Mar 17, 2024

Hi @jdeniau,

I'm the CEO and co-founder of FlyCI, thank you for giving our Mac runners a try!

[Edit] I noticed that you decided to remove FlyCI, do you mind sharing some feedback on what was the reason you decided against using FlyCI?

@jdeniau
Copy link
Owner Author

jdeniau commented Mar 18, 2024

Hi @kgantchev

I tried flyci as I didn't found that macos-14github runner run's on arm.
In Flyci, I had a sign issue with electron packager, so I tried back github arm runner (found in between).
I has the same issue on my mac though, and in fact, it was related to the number of opened file on arm !

I resolved with https://github.com/jdeniau/tiana-tables/pull/59/files
and opened electron/forge#3540 on the electron side to make debug easier.

I think I will kept the github runner for the following reason :

  • My package is quite a small application for now, and I do not have huge requirements,
  • I build for both windows, linux and mac, so I prefer keeping all my CI in the same spot,
  • I trust github more than I do trust flyci,
  • Your application asks for "Read and write access to administration" : it may be required, but I feel unsafe giving you that access.

What I can grant your service though:

  • Installation is super easy, I did not think that an external service could be that easy,
  • the build seems to be really faster than github's (but I did not timed it, and it's your marketing, so my brain may have been tricked)

@jdeniau
Copy link
Owner Author

jdeniau commented Mar 18, 2024

(closing this for the record as problem was solved in #59 )

@jdeniau jdeniau closed this Mar 18, 2024
@jdeniau jdeniau deleted the test-flyci branch March 18, 2024 10:58
@kgantchev
Copy link

Thanks for providing us with this insightful feedback! I appreciate you giving FlyCI a shot and I'll take your feedback to our team.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants