feat: button icons disabled state #163
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
arturbien
force-pushed
the
feat/ab/disabled-filter
branch
from
12110ad
to
cf060d6
Compare
arturbien
force-pushed
the
feat/ab/disabled-filter
branch
from
cf060d6
to
c402504
Compare
arturbien
force-pushed
the
feat/ab/disabled-filter
branch
from
c402504
to
db81f5e
Compare
arturbien
force-pushed
the
feat/ab/disabled-filter
branch
from
db81f5e
to
9e78cf3
Compare
arturbien
force-pushed
the
feat/ab/disabled-filter
branch
from
9e78cf3
to
cc0ab5b
Compare
|
@jdan any thoughts on this PR? |
|
This looks great! Would you add a comment to the SVG defs so users know that it's important to import them to their markup? If you do that + pull main I think we can merge this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds custom SVG filter for the disabled effect used across Win 98.
The filter is applied by default to images inside the
<button />.Filter can also be used on any other element outside the button if needed:
The filter unfortunately can not be inlined inside CSS because for some reason
<feFlood />is not working when inlined.Instead the SVG filter needs to be defined in the DOM, then referenced in CSS.