parameterize all colors in css #107
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/jdan/98css/348JHLLmynpm6AYUmNXp6Eph8VKi |
jdan
reviewed
Mar 16, 2021
| width: 8px; | ||
| height: 9px; | ||
| line-height: 8px; | ||
| margin-right: 5px; | ||
| padding-left: 1px; | ||
| background-color: #fff; | ||
| background-color: var(--control-outline); |
| @@ -686,7 +694,7 @@ code * { | |||
| } | |||
|
|
|||
| summary:focus { | |||
| outline: 1px dotted #000000; | |||
| outline: 1px dotted (--control-outline); | |||
|
My apologies - a lot of work has already been done in #94 so I'm going to close this as a dupe and revisit that one. Feel free to chime in there with any ideas. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR parameterizes all colors in the main
style.cssfile. Ideally I'd say this was to make everything more consistent, but in reality it will make future work to theme on top of this much easier (e.g., Dark Windows 98 theme? Yes, please.) I tried to re-use existing color variables where possible, and introduced others where neccesary.This doesn't address colors in the SVG icons, so that's left as an exercise for a future day.
No output differences were observed in the display of the sample
index.html.ejsfile, but other eyes are certainly welcome.