Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add context menu options to restrict the minimum and maximum value of FX parameters in OSARA's FX Parameters dialog. #1212

Merged
merged 1 commit into from
Mar 21, 2025

Conversation

jcsteh
Copy link
Owner

@jcsteh jcsteh commented Mar 16, 2025

Fixes #1195.

… FX parameters in OSARA's FX Parameters dialog.
Copy link
Contributor

@jcsteh
Copy link
Owner Author

jcsteh commented Mar 16, 2025

This pull request courtesy of a 35 minute Uber ride in which I had nothing to do. :)

@HenriNH6, @Drizzell, can you try the build linked in #1212 (comment) and let me know if this works for you in practice?

@HenriNH6
Copy link

Hi @jcsteh,
Sorry it took me a while to test this. I've talked about it with @Drizzell too, and we're really happy with how the feature works - it's awesome!
I just had one small suggestion: Would it be possible to keep the lower and upper limits of a parameter active, even after closing the plugin window (like pressing Escape) or switching to another parameter in the same plugin? Right now, the limits reset when I do either of those things. It would be great if the limits stayed until I manually clear them from the context menu.
Even so, we are both very grateful for this feature, and we're really happy that OSARA has it.
Thanks a lot for all your work on this feature - it's super useful!

@ScottChesworth
Copy link
Collaborator

If these settings persist, we would need a way of notifying when a parameter has been range restricted.

@jcsteh
Copy link
Owner Author

jcsteh commented Mar 21, 2025

Remembering the restrictions across invocations is tricky in terms of both user experience (the concern Scott flagged) and implementation (how to reliably store the limits associated to a particular parameter, etc.). It's not something I'm able to dig into right now, even assuming it's possible to make it reliable.

@jcsteh jcsteh marked this pull request as ready for review March 21, 2025 22:26
@jcsteh jcsteh merged commit 42676cd into master Mar 21, 2025
3 checks passed
@jcsteh jcsteh deleted the restrict branch March 21, 2025 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Osara parameter plugin dialog - ability to lock parameter range
3 participants