Keymap june24

[ScottChesworth]

Includes all changes proposed in #1076 for wider testing

[AppVeyorBot]

Build succeeded! Build osara pr1127-1562,11883f6f completed (commit 11883f6f0c by @ScottChesworth)
Downloads:

Windows

• installer/osara_pr1127-1562,11883f6f.exe
• locale/osara_pr1127-1562,11883f6f.pot

Mac

• installer/osara_pr1127-1562,11883f6f.dmg

[AppVeyorBot]

Build succeeded! Build osara pr1127-1564,9a234b17 completed (commit 9a234b175b by @ScottChesworth)
Downloads:

Windows

• installer/osara_pr1127-1564,9a234b17.exe
• locale/osara_pr1127-1564,9a234b17.pot

Mac

• installer/osara_pr1127-1564,9a234b17.dmg

[AppVeyorBot]

Build succeeded! Build osara pr1127-1567,78d212b4 completed (commit 78d212b4ab by @ScottChesworth)
Downloads:

Windows

• installer/osara_pr1127-1567,78d212b4.exe
• locale/osara_pr1127-1567,78d212b4.pot

Mac

• installer/osara_pr1127-1567,78d212b4.dmg

[jcsteh]

Minor points for future reference/thought:

1. I'd really prefer to have the summary of key map changes included in the commit message. Having it separate means we lose track of it in the commit history and it's unclear what changed in a given commit.
2. For big key map changes, I don't think code changes should be included in the same commit. I think it's fine to include a single key map change in the same commit as a single code change. However, when it's a larger key map commit, again it gets blurry what is changing and why.

[ScottChesworth]

Ah sorry about that, will keep those points in mind next time. I only included code here because I goofed, thought some feedback I implemented in another PR had already been merged. You'd already reviewed the other PR, so the code itself should be up to snuff.

[jcsteh]

Yeah, the code is fine, just purely about organisation and history. It's no biggy, just things for future reference. Thanks.