This repository has been archived by the owner on Oct 3, 2024. It is now read-only.
Alpha #56
Open
Alpha #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…from redis event bus reciever
Fetch events domain events one by one instead all in memory
on the command handler and the repository is alted oterwise it could create deadlocks
Entity bases, otherwize may be undefined
| }); | ||
| } else { | ||
| createApp(); | ||
| createApp(function() { |
There was a problem hiding this comment.
createApp(callback)?
|
I was considering this for a merge. Do you plan on resubmitting this? |
|
There have been some new commits on the event stores, domain repository and entity instantiator. We should take some times to pick the commits and submit a new pull request.— On Sat, Sep 27, 2014 at 2:58 PM, Julien Biezemans
|
|
Branch has been restored as it was last week. |
|
Do you consider it complete or should we wait for some other pending commits? |
|
It would be better to wait for the other commits. However, you'll have a lot more to review. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some improvements and bug fixes after using it on our app