When jboss-release is in effect, release to r.j.o
#244
Conversation
| @@ -821,7 +821,8 @@ | |||
| <groupId>org.apache.maven.plugins</groupId> | |||
| <artifactId>maven-deploy-plugin</artifactId> | |||
| <configuration> | |||
| <updateReleaseInfo>true</updateReleaseInfo> | |||
There was a problem hiding this comment.
This was removed because this is no longer a valid configuration option for this plugin (since ???).
| <altReleaseDeploymentRepository>${jboss.releases.repo.id}::${jboss.releases.repo.url}</altReleaseDeploymentRepository> | ||
| <altSnapshotDeploymentRepository>${jboss.snapshots.repo.id}::${jboss.snapshots.repo.url}</altSnapshotDeploymentRepository> |
There was a problem hiding this comment.
This seems fine to me. It looks like you could just use altDeploymentRepository and it will use that if either of the other two are null.
There was a problem hiding this comment.
That's fair, but since we have separate releases and snapshots this seemed to be more correct. That said: there would be different behaviors since if someone gives altDeploymentRepository (rather than altXxxxDeploymentRepository) on the command line or in their POM, I think it would be ignored with this configuration. I'm OK with either solution (specifically, leaving this as-is versus changing altReleaseDeploymentRepository to altDeploymentRepository). WDYT?
There was a problem hiding this comment.
As Brian mentioned in chat, normally people should use the properties to customize the definition anyway... maybe.
|
I said this in chat but I'll say it here too, as this may be a better historical record. This changes the semantics of the jboss-release profile, but only for projects that are 1) using jboss-release and 2) using their own distributionManagement section instead of relying on this pom entirely or using the maven properties involved in this PR that used to drive the behavior of this pom's now-removed distributionManagement. I think that's a corner case, perhaps non-existent, so I approved this. |
This takes the place of specifying
distributionManagement, which was removed in 0070843.