doc theme_result extension #343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
resolves #323
|
Looks good -- I'm okay with this as is, but I haven't see the term "showcase" used for this before. Not sure I have a better term though. |
|
I couldn't think of a better term either. The extension isn't really specific to the theme, so "Theme Result" (as the module is named) or "Theme Demonstration" (despite vagueness and overuse) isn't really adequate. "Showcasing" might be a cultural term (eg. a collector's usage as a verb), but I have seen it used like this before. I just can't think of a specific example from past experiences. |
jbms
approved these changes
Jun 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #323