Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@jazzido @jspeis just wanted to start the conversation about patching the race condition on connection init.
As far as I can tell, this patch fixes NilClass errors that were occurring when there were near-simultaneous requests to MondrianRest.
Previously, constructing the connection and connecting occurred on the first api request. Since connecting took some time, there would be a moment when
@@olap
was no longer nil, but the new mondrian connection was not yet ready for use (resulting in, we think, theNilClass
errors).With this patch, now those initialization steps are done in the config.ru.
There's probably a better way to do this, so please let us know what you think @jazzido . This would be a pretty big breaking change if it had to be done in
config.ru