-
-
Notifications
You must be signed in to change notification settings - Fork 595
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support column_width in xlsx format #516
Open
Birdi7
wants to merge
18
commits into
jazzband:master
Choose a base branch
from
Birdi7:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+100
−2
Open
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
80ab473
feat: support column_width in xlxs format
Birdi7 7a903b6
Update docs/formats.rst
Birdi7 7fbbd9d
chore: add tests for adaptive column width in xlsx format
Birdi7 c1196d6
chore: change assert style
Birdi7 6811201
Update src/tablib/formats/_xlsx.py
Birdi7 19c0c58
Update src/tablib/formats/_xlsx.py
Birdi7 f6a9664
chore: alphabetical order in AUTHORS
Birdi7 d42f313
chore: docs
Birdi7 618930a
chore: add tests and fix bug
Birdi7 7bfafaa
refactor: helper function for tests and new test case for error
Birdi7 eeca7e5
chore: use from __future__ import annotations
Birdi7 be9db5e
Update tests and code for easier reading
andrewgy8 af35169
Update format doc for clarity
andrewgy8 c3fcf8d
Update message format for exception raised
andrewgy8 c29c9dd
Linting and formatting
andrewgy8 fd73a96
Linting and formatting
andrewgy8 6d1a7fa
Add history entry
andrewgy8 3bed224
Fix history versioning
andrewgy8 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you think about accepting a list of column widths to be able to set widths per column? It may also be a follow-up improvement PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I think that would be a valid iteration on this change 👍