Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refs #256 - Implement class-based formats #395

Merged
merged 1 commit into from
Nov 2, 2019

Conversation

claudep
Copy link
Contributor

@claudep claudep commented Oct 5, 2019

This allows to extend Tablib with new formats far more easily.

@claudep
Copy link
Contributor Author

claudep commented Oct 5, 2019

Failure on Python 2.7 is expected. This will not be pushed before the Python 2.7 support is dropped.

@codecov
Copy link

codecov bot commented Oct 19, 2019

Codecov Report

Merging #395 into master will increase coverage by 0.5%.
The diff coverage is 93.68%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #395     +/-   ##
=========================================
+ Coverage   88.57%   89.08%   +0.5%     
=========================================
  Files          24       24             
  Lines        2390     2482     +92     
=========================================
+ Hits         2117     2211     +94     
+ Misses        273      271      -2
Impacted Files Coverage Δ
src/tablib/formats/_csv.py 100% <100%> (ø) ⬆️
src/tablib/formats/_html.py 100% <100%> (ø) ⬆️
src/tablib/formats/_yaml.py 100% <100%> (ø) ⬆️
src/tablib/formats/_dbf.py 100% <100%> (ø) ⬆️
src/tablib/formats/_tsv.py 100% <100%> (ø) ⬆️
src/tablib/formats/_json.py 97.36% <100%> (+0.49%) ⬆️
src/tablib/formats/_latex.py 100% <100%> (ø) ⬆️
src/tablib/formats/_jira.py 100% <100%> (ø) ⬆️
tests/test_tablib.py 98.4% <100%> (+0.03%) ⬆️
src/tablib/formats/_df.py 76.92% <81.81%> (+4.19%) ⬆️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d21bd10...483a1ae. Read the comment docs.

docs/development.rst Outdated Show resolved Hide resolved
This allows to extend Tablib with new formats far more easily.
@claudep claudep merged commit f1046cd into jazzband:master Nov 2, 2019
@claudep claudep deleted the registry branch November 2, 2019 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants