Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pull request write permission to i18n updater #770

Merged
merged 1 commit into from
Dec 15, 2023

Conversation

Andrew-Chen-Wang
Copy link
Member

Trying this again.

Copy link
Member

@50-Course 50-Course left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Andrew-Chen-Wang,

Thank you for making this PR. No comments over here other than the little question up there and I should approve. Quite interesting, there is no main branch but it is been left on the workflow.yml config - calling your attention it. 😃

@50-Course 50-Course self-requested a review December 7, 2023 00:48
@50-Course
Copy link
Member

@Andrew-Chen-Wang I think this is all good. Should be approving this PR in a few.

@Andrew-Chen-Wang
Copy link
Member Author

feel free to change anything in the branch. currently ooo

Copy link
Member

@50-Course 50-Course left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏼

@50-Course 50-Course merged commit fc03667 into master Dec 15, 2023
34 checks passed
@50-Course 50-Course deleted the andrew/i18n-updater branch December 15, 2023 00:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants