Drop unsupported django 4.0, 4.1 #180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WhyNotHugo
approved these changes
Jan 17, 2024
|
@WhyNotHugo , I dont know, but I think you should somehow approve workflow |
|
@WhyNotHugo , just a kind remainder to check this PR. I hope it's not annoying :( |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #180 +/- ##
=======================================
Coverage 97.67% 97.67%
=======================================
Files 17 17
Lines 689 689
Branches 56 56
=======================================
Hits 673 673
Misses 10 10
Partials 6 6 ☔ View full report in Codecov by Sentry. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Solves #169
I didn't test it locally, I hope gh runner would say everything is okey.
I don't know if I should fix pypi classifier from
"Framework :: Django :: 4.0"to"Framework :: Django :: 4.2". I guess it's related to pypi index and SEO so I would not do it without real reason.I'm also thinking to remove py37 runtime (https://endoflife.date/python) but I guess it's a lot of work. If you know it's easier than I think (just removing some lines in gh flows and tox tests), I would do it in this PR.