Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update middleware to enhanced extra IP for client #115

Closed
wants to merge 1 commit into from
Closed

Update middleware to enhanced extra IP for client #115

wants to merge 1 commit into from

Conversation

EngFarisAlsmawi
Copy link

@EngFarisAlsmawi EngFarisAlsmawi commented Apr 26, 2020

Description

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • [x ] New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov
Copy link

codecov bot commented Apr 26, 2020

Codecov Report

Merging #115 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #115   +/-   ##
=======================================
  Coverage   88.92%   88.92%           
=======================================
  Files          10       10           
  Lines         280      280           
  Branches       31       31           
=======================================
  Hits          249      249           
  Misses         23       23           
  Partials        8        8           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e38709e...4998c1b. Read the comment docs.

@Bouke
Copy link
Collaborator

Bouke commented Jun 21, 2020

This is a bad idea and would make applications vulnerable to IP spoofing. See also #56 and various other tickets.

@Bouke Bouke closed this Jun 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants