Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prefetching users to avoid N+1 queries #107

Merged
merged 1 commit into from
Jun 21, 2020
Merged

Prefetching users to avoid N+1 queries #107

merged 1 commit into from
Jun 21, 2020

Conversation

abithyzis
Copy link
Contributor

Description

Prefetching users to avoid one query for each user session displayed

Motivation and Context

Refs #94

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov
Copy link

codecov bot commented Jan 27, 2020

Codecov Report

Merging #107 into master will increase coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #107      +/-   ##
==========================================
+ Coverage   88.92%   88.96%   +0.03%     
==========================================
  Files          10       10              
  Lines         280      281       +1     
  Branches       31       31              
==========================================
+ Hits          249      250       +1     
  Misses         23       23              
  Partials        8        8
Impacted Files Coverage Δ
user_sessions/admin.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 61ee7f3...edf129e. Read the comment docs.

@Bouke
Copy link
Collaborator

Bouke commented Jan 27, 2020

Looks like a good PR. I'll merge it after the jazzband configuration has been resolved: #105 (comment).

@Bouke Bouke merged commit 0c5337b into jazzband:master Jun 21, 2020
@abithyzis abithyzis deleted the patch-1 branch June 23, 2020 15:31
@blag blag mentioned this pull request Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants