Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Jazzband guidelines for django-user-sessions #105

Open
10 of 13 tasks
jazzband-bot opened this issue Jan 24, 2020 · 17 comments
Open
10 of 13 tasks

Implement Jazzband guidelines for django-user-sessions #105

jazzband-bot opened this issue Jan 24, 2020 · 17 comments
Assignees

Comments

@jazzband-bot
Copy link
Contributor

jazzband-bot commented Jan 24, 2020

This issue tracks the implementation of the Jazzband guidelines for the project django-user-sessions

It was initiated by @Bouke who was automatically assigned in addition to the Jazzband roadies.

See the TODO list below for the generally required tasks, but feel free to update it in case the project requires it.

Feel free to ping a Jazzband roadie if you have any question.

TODOs

Project details

Description Extend Django sessions with a foreign key back to the user, allowing enumerating all user's sessions.
Homepage https://pypi.python.org/pypi/django-user-sessions
Stargazers 291
Open issues 17
Forks 79
Default branch master
Is a fork False
Has Wiki False
Has Pages False
@Bouke
Copy link
Collaborator

Bouke commented Jan 24, 2020

/cc @ricco386

@Bouke
Copy link
Collaborator

Bouke commented Jan 24, 2020

@jezdez when I add a "Github incoming webhook" on readthedocs, I'm getting the following error:

Could not add webhook for Django User Sessions. Make sure you have the correct GitHub permissions.
The project Django User Sessions doesn't have a valid webhook set up, commits won't trigger new builds for this project. See the project integrations for more information.

Any suggestions?

@Bouke
Copy link
Collaborator

Bouke commented Jan 24, 2020

@jezdez the project uses Transifex to handle translations. How is this typically handled in Jazzband?

@Bouke
Copy link
Collaborator

Bouke commented Jan 24, 2020

There's a PR pending review to address the branding: #106.

@Bouke
Copy link
Collaborator

Bouke commented Jan 27, 2020

@jezdez There's currently no-one with admin permissions on this repository. There's currently a faulty status check which is blocking merging PRs. How's that typically setup for jazzband repos?

@ricco386
Copy link

In PR #106 we have started the discussion about transifex public contributors page, and the possibility to drop the support and do a manual translations...

Since the transifex already has some contributors it might be contra-productive to drop the support, because the project might loose someone who is interested in help out but is not entirely technical to do the translations manually. @Bouke do you know if there are only people who have contributed with code, or are there also people who haven't contributed on github?

Since I have volunteered to maintain this project at jazzband I don't mind to create account on transifex and manage there as well... The downside I can see is that transifex contributors wont be listed in the repo...

@Bouke
Copy link
Collaborator

Bouke commented Feb 4, 2020

Any suggestions on getting the admin permissions resolved? (ping @jezdez)

@Bouke
Copy link
Collaborator

Bouke commented Feb 15, 2020

Also posted here: jazzband/help#184

@jezdez
Copy link
Member

jezdez commented Feb 15, 2020

Losing admin permissions is an expected side effect of this. I'll follow up for the left-over tasks ASAP.

@Bouke
Copy link
Collaborator

Bouke commented Feb 15, 2020

@jezdez I can’t merge any PRs because the PR checks are failing. I can’t disable the checks as I’m not an admin. Are you the only one who can fix that? #108

@Bouke
Copy link
Collaborator

Bouke commented Feb 23, 2020

@jezdez I still can’t merge PRs. E.g. #108.

@Bouke
Copy link
Collaborator

Bouke commented Apr 3, 2020

@jezdez The problem is that the PR checks are not configured correctly. As I have no admin permissions, I can't resolve these problems. Either you fix those permissions, or you make me admin, or you transfer the repository back to me. Your choice :).

https://github.community/t5/How-to-use-Git-and-GitHub/Cannot-merge-PR-quot-some-checks-haven-t-completed-yet-quot-but/m-p/50127#M10871

The solution is easy, but only by someone with admin rights. They need to edit the branch rules and remove the "Expected" checkbox from the two stale checks.

jezdez added a commit that referenced this issue Jun 7, 2020
@jezdez
Copy link
Member

jezdez commented Jun 7, 2020

@Bouke The only things missing from the TODO list above is transferring the Transifex project and setting up the semiautomatic package releases which I would need to know who the project lead(s) should be.

@Bouke
Copy link
Collaborator

Bouke commented Jun 21, 2020

@jezdez To whom would I transfer Transifex ownership, is there some Jazzband organisation? As an alternative we could just drop Transifex and have translations contributed directly through Github.

@ricco386 Is setting up semiautomatic package releases something that you can take care of? And can @jezdez list you as project lead?

@jezdez
Copy link
Member

jezdez commented Dec 21, 2020

@Bouke There is a Jazzband team already at Transifex that we've used to translate a few of the Jazzband projects: https://www.transifex.com/jazzband/ It's not very well maintained though, and I'm not sure if it's worth the extra effort. I leave it to @ricco386 to decide which way to go.

@jezdez
Copy link
Member

jezdez commented Dec 21, 2020

@ricco386 BTW, I've added you as project lead (finally!): https://jazzband.co/projects/django-user-sessions

@Bouke Want me to add you as a fallback?

@jezdez
Copy link
Member

jezdez commented Dec 21, 2020

Oh, by the way, the code in #126 also adds the missing pieces for the project release semi-automation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants