Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Django 2.0 #83

Merged
merged 10 commits into from
Dec 11, 2017
Merged

Django 2.0 #83

merged 10 commits into from
Dec 11, 2017

Conversation

tony
Copy link
Member

@tony tony commented Dec 7, 2017

See #81 (comment)

Fixes include:

  • Dropping support for 1.10 and below (pending confirmation at Drop 1.10 and below? #82, preliminarily added)

  • Fixes for URL imports

    • Fix javascript_catalog (reasons: unused in tests, rm'd in django 2.0)
    • include() style fixes for admin.site.urls
    • Conditional importing of url modules for backward compatibility
  • Fixes for .is_authenticated()

  • Update tox and travis to test 2.0

  • Update trove classifiers and README

@codecov
Copy link

codecov bot commented Dec 7, 2017

Codecov Report

Merging #83 into master will decrease coverage by 0.98%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #83      +/-   ##
=========================================
- Coverage   65.69%   64.7%   -0.99%     
=========================================
  Files           7       5       -2     
  Lines         137     136       -1     
  Branches       15      16       +1     
=========================================
- Hits           90      88       -2     
  Misses         41      41              
- Partials        6       7       +1
Impacted Files Coverage Δ
robots/views.py 75% <100%> (+1.15%) ⬆️
robots/settings.py 87.5% <0%> (-12.5%) ⬇️
robots/south_migrations/__init__.py

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ab5362e...3ddead7. Read the comment docs.

@tony
Copy link
Member Author

tony commented Dec 7, 2017

I can't rerun this: https://travis-ci.org/jazzband/django-robots/jobs/313061621 Can someone try?

@tony
Copy link
Member Author

tony commented Dec 7, 2017

I can't rerun this: https://travis-ci.org/jazzband/django-robots/jobs/313061621 Can someone in @jazzband try?

@tony
Copy link
Member Author

tony commented Dec 7, 2017

Using this in production @ https://devel.tech/

@tony tony merged commit 879a04f into jazzband:master Dec 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant