-
-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix pkg_resources deprecation warning #146
Conversation
Codecov Report
@@ Coverage Diff @@
## master #146 +/- ##
==========================================
+ Coverage 80.57% 87.21% +6.63%
==========================================
Files 8 12 +4
Lines 139 305 +166
Branches 13 28 +15
==========================================
+ Hits 112 266 +154
- Misses 20 28 +8
- Partials 7 11 +4
... and 4 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thx
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@tony Yep, works perfectly. Thank you for the quick turnaround! |
@blag Great! |
Running with Python 3.11 generates the following warning:
This PR attempts to first import
importlib.metadata.version
before falling back to usingpkg_resources.get_distribution
.