Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in RuleAdminForm validation error message #145

Closed
wants to merge 1 commit into from

Conversation

apoorvaeternity
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Jan 11, 2023

Codecov Report

Merging #145 (8570239) into master (7175419) will increase coverage by 6.46%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #145      +/-   ##
==========================================
+ Coverage   80.57%   87.04%   +6.46%     
==========================================
  Files           8       12       +4     
  Lines         139      301     +162     
  Branches       13       28      +15     
==========================================
+ Hits          112      262     +150     
- Misses         20       28       +8     
- Partials        7       11       +4     
Impacted Files Coverage Δ
src/robots/forms.py 72.72% <ø> (ø)
src/robots/migrations/0001_initial.py 100.00% <0.00%> (ø)
src/robots/migrations/__init__.py 50.00% <0.00%> (ø)
src/robots/migrations/0002_alter_id_fields.py 100.00% <0.00%> (ø)
src/robots/tests.py 93.91% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@tony
Copy link
Member

tony commented Sep 7, 2023

I overlooked this PR - I apologize.

This same change was swept in e983341 when I ran typos on the codebase.

Fine if I still give you credit in the CHANGELOG? Even if the changeset isn't in the git history itself?

Again, my mistake.

@tony
Copy link
Member

tony commented Sep 7, 2023

@apoorvaeternity Directly mentioning you also, in regards to the above comment.

@apoorvaeternity
Copy link
Member Author

apoorvaeternity commented Sep 7, 2023

Fine if I still give you credit in the CHANGELOG? - @tony that's completely fine :)

tony added a commit that referenced this pull request Sep 7, 2023
This was duplicated by a typos cli run in e983341.

It was my bad not to look at the PR before running. Credit the contributor here.
@tony
Copy link
Member

tony commented Sep 7, 2023

@apoorvaeternity How is this?

@apoorvaeternity
Copy link
Member Author

@tony it's perfect. Closing this PR now.

@tony
Copy link
Member

tony commented Sep 11, 2023

Hooray! Good this worked out!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants