refactor!: poetry, github action overhaul, pyenv / asdf versions #137
Conversation
tony
force-pushed
the
poetry-py.test
branch
3 times, most recently
from
f570809 to
1dc921f
Compare
| - name: Publish package | ||
| if: github.event_name == 'push' && startsWith(github.ref, 'refs/tags') | ||
| uses: pypa/gh-action-pypi-publish@release/v1 | ||
| with: | ||
| user: __token__ | ||
| password: ${{ secrets.PYPI_API_TOKEN }} | ||
| skip_existing: true |
There was a problem hiding this comment.
This should not be done here but in the release.yml file instead. Please don't push to PyPI directly, too.
There was a problem hiding this comment.
That's true ☝️ And I know why that'd be. This is copied from my own project's workflows (it wasn't meant to be added)
| @@ -0,0 +1,24 @@ | |||
| session_name: django-robots | |||
| @@ -0,0 +1,2 @@ | |||
| poetry 1.2.1 | |||
There was a problem hiding this comment.
This isn't needed for development should be kept on your machine.
|
@jezdez I meant to close this PR. This was just experimenting ^ |
hatch, that's totally new to me!
I'm happy to contribute that in a separate PR (and even try hatch out) That said - the bigger issue I'm concerned about is #124. @jezdez What are your thoughts on this project here and now? Am I doing more harm than good? Do you want to pilot it again? (I notice this specific django package is your creation, on atop of your being apart of jazzband). Can / should I email you? |
|
For now I will close this - per #137 (comment) |
|
Where I took this:
|
fyi Hatch can pretty robustly automate that https://hatch.pypa.io/latest/intro/#existing-project |
|
I did one 🙂 django-commons/django-debug-toolbar#1690 |
Fixes #136