Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set default auto field to BigAutoField #134

Merged
merged 2 commits into from
Oct 15, 2022

Conversation

jan-szejko-steelseries
Copy link
Contributor

@codecov
Copy link

codecov bot commented Oct 6, 2022

Codecov Report

Merging #134 (8f13c49) into master (f9ccab4) will increase coverage by 0.72%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #134      +/-   ##
==========================================
+ Coverage   79.85%   80.57%   +0.72%     
==========================================
  Files           7        8       +1     
  Lines         134      139       +5     
  Branches       22       13       -9     
==========================================
+ Hits          107      112       +5     
  Misses         20       20              
  Partials        7        7              
Impacted Files Coverage Δ
src/robots/__init__.py 100.00% <100.00%> (ø)
src/robots/apps.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@tony tony mentioned this pull request Oct 12, 2022
Copy link
Member

@tony tony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested via

env PYTHONPATH=. DJANGO_SETTINGS_MODULE=tests.settings django-admin test robots -v2

Before (at 77b980c)

env PYTHONPATH=. DJANGO_SETTINGS_MODULE=tests.settings django-admin test robots -v2
WARNINGS:
?: (admin.W411) 'django.template.context_processors.request' must be enabled in DjangoTemplates (TEMPLATES) in order to use the admin navigation sidebar.
robots.Rule: (models.W042) Auto-created primary key used when not defining a primary key type, by default 'django.db.models.AutoField'.
        HINT: Configure the DEFAULT_AUTO_FIELD setting or the AppConfig.default_auto_field attribute to point to a subclass of AutoField, e.g. 'django.db.models.BigAutoField'.
robots.Url: (models.W042) Auto-created primary key used when not defining a primary key type, by default 'django.db.models.AutoField'.
        HINT: Configure the DEFAULT_AUTO_FIELD setting or the AppConfig.default_auto_field attribute to point to a subclass of AutoField, e.g. 'django.db.models.BigAutoField'.

With PR

env PYTHONPATH=. DJANGO_SETTINGS_MODULE=tests.settings django-admin test robots -v2

Warnings:

?: (admin.W411) 'django.template.context_processors.request' must be enabled in DjangoTemplates (TEMPLATES) in order to use the admin navigation sidebar.

Release

I will:

  • Merge to master (6.x branch)
  • Make a 5.x branch for this, backport this, and release it under a beta

@tony tony merged commit 7e195db into jazzband:master Oct 15, 2022
tony pushed a commit that referenced this pull request Oct 15, 2022
In re: #124 missing migration

This may, in turn, create migrations for those who manually created them.  Each situation depends on the system
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants