Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add django 3.2 and 4.0 support #112

Merged
merged 2 commits into from
Oct 6, 2021
Merged

add django 3.2 and 4.0 support #112

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
18c84b6
add django 3.2 and 4.0 support
Sep 23, 2021
91adf53
address feedback
Oct 5, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGES.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,10 @@ master (unreleased)
- Dropped support for Python 2.7 and 3.5
- Added support for Python 3.9
- Dropped support for Django versions 2.1 and below
- Dropped support for Django 3.0
- Added suppport for Django 3.1
- Added suppport for Django 3.2
- Added support for Django 4.0

4.0 (2020-01-04)
-----------------
Expand Down
3 changes: 2 additions & 1 deletion README.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,9 @@ directory or on ReadTheDocs: https://django-robots.readthedocs.io/
Supported Django versions
-------------------------

umarmughal824 marked this conversation as resolved.
Show resolved Hide resolved
* Django 4.0
* Django 3.2
* Django 3.1
* Django 3.0
* Django 2.2

For older Django versions (1.6-1.10) use ``django-robots==3.0``.
Expand Down
3 changes: 2 additions & 1 deletion setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,8 @@ def read(*parts):
'Programming Language :: Python :: 3.8',
'Framework :: Django',
'Framework :: Django :: 2.2',
'Framework :: Django :: 3.0',
'Framework :: Django :: 3.1',
'Framework :: Django :: 3.2',
'Framework :: Django :: 4.0',
]
)
23 changes: 23 additions & 0 deletions src/robots/migrations/0002_alter_id_fields.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
# Generated by Django 3.2 on 2021-09-23 12:14

from django.db import migrations, models


class Migration(migrations.Migration):

dependencies = [
('robots', '0001_initial'),
]

operations = [
migrations.AlterField(
model_name='rule',
name='id',
field=models.BigAutoField(auto_created=True, primary_key=True, serialize=False, verbose_name='ID'),
),
migrations.AlterField(
model_name='url',
name='id',
field=models.BigAutoField(auto_created=True, primary_key=True, serialize=False, verbose_name='ID'),
),
]
6 changes: 4 additions & 2 deletions tox.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,8 @@
envlist =
# list of supported Django/Python versions:
# https://docs.djangoproject.com/en/3.1/faq/install/#what-python-version-can-i-use-with-django
py{36,37,38,39}-dj{22,30,31}
py{36,37,38,39}-dj{22,31,32}
py{38,39}-dj{40}
py{38,39}-djmain
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add Django 4.0 support as well while we're here?

Copy link
Contributor Author

@umarmughal824 umarmughal824 Sep 27, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't get any chance to explore Django 4 yet but I will see if it's a quick fix.

Copy link
Contributor Author

@umarmughal824 umarmughal824 Sep 28, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@smithdc1 Django 4.0 is not yet final so better to wait for the final release which is due in December.
https://code.djangoproject.com/wiki/Version4.0Roadmap

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's final in terms of features and changes. The only patches being applied to the 4.0 branch are bug fixes. Folk are adding the classifier to their packages already. See:

https://pypi.org/search/?c=Framework+%3A%3A+Django+%3A%3A+4.0

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@smithdc1 I'm waiting for your review, thanks

py38-{lint,docs}

Expand All @@ -25,8 +26,9 @@ commands =
deps =
-r{toxinidir}/tests/requirements.txt
dj22: django>=2.2,<2.3
dj30: django>=3.0,<3.1
dj31: django>=3.1,<3.2
dj32: django>=3.2,<3.3
dj40: django>=4.0a1,<4.1
djmain: https://github.com/django/django/archive/main.tar.gz

[testenv:py38-lint]
Expand Down