Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test infrastructure, packaging, etc. needs overhaul #136

Closed
tony opened this issue Oct 15, 2022 · 3 comments
Closed

Test infrastructure, packaging, etc. needs overhaul #136

tony opened this issue Oct 15, 2022 · 3 comments

Comments

@tony
Copy link
Member

tony commented Oct 15, 2022

Here is all a user should need to bootstrap themselves:

poetry install

And to test:

poetry run py.test

It seems that tox is set as a requirement, not a supplement, to testing on the django-robots - blocking any hope of accomplishing even basic tasks.

CI could use test matrix to get django

This is needed for #133 and for future maintainers #135
This was referenced Oct 15, 2022
Merged
Closed
Closed
@tony
Copy link
Member Author

tony commented Oct 15, 2022

Note: As-is, of 5.0 at 77b980c, here's how tests can be ran:

env PYTHONPATH=. DJANGO_SETTINGS_MODULE=tests.settings django-admin test robots -v2

tony added a commit that referenced this issue Oct 15, 2022
@tony
docs: Add notes on running tests locally
e9c3c22 
See also: #136
@jezdez
Copy link
Member

jezdez commented Oct 16, 2022

I disagree that tox is a blocker for any of this, but I see why you'd feel that way since currently the test setup isn't using tox-gh-actions that allows mapping GitHub action matrix items to tox configuration and vice versa. I'd recommend doing that before flipping a table and go with Poetry.

@tony
Copy link
Member Author

tony commented Oct 16, 2022

@jezdez I am fine with that.

I will close this and note the preference for https://pypi.org/project/tox-gh-actions/

@tony tony closed this as completed Oct 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor!: poetry, github action overhaul, pyenv / asdf versions tony/django-robots
2 participants
@jezdez @tony