Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use only required fields in stripe js #98

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

artursmet
Copy link
Contributor

Stripe doesn't require address, to create card token: https://stripe.com/docs/api#create_card_token

@patrys
Copy link
Contributor

patrys commented Nov 18, 2015

@mociepka?

@mociepka
Copy link
Contributor

It doesn't require it but you can provide them. Management from stripe account will be simpler with all data.

@artursmet
Copy link
Contributor Author

In my opinion we shouldn't force to provide address data. There are checkout systems, collecting only basic data like email and credit card details. It'll be more universal I think

@patrys
Copy link
Contributor

patrys commented Nov 18, 2015

Can you provide screenshots of before and after? Can we somehow send the data that we have to Stripe without prompting the user?

@artursmet
Copy link
Contributor Author

With address data, stripe does some additional checks I think:

With data:
stripe_with_data

Without:
stripe_without_data

But it looks like Street check and Zip check are not so strict (passed with Polish zip code and US as a country)

From end user perspective there is no difference (we're sending address data as data attributes of stripe input)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants