Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use JSONField for BasePayment.attrs #306

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Use JSONField for BasePayment.attrs #306

wants to merge 2 commits into from

Conversation

WhyNotHugo
Copy link
Member

Need to wait until Django 2.2 is EOL.

@mariofix
Copy link
Member

mariofix commented May 6, 2023

Hi! I'm actually wanting to use this, since 2.2 has already been dropped, can I give you a hand with this?

@WhyNotHugo
Copy link
Member Author

I've rebased this, but it would be good to have some more testing before merging it.

@mariofix
Copy link
Member

mariofix commented May 25, 2023

I'll start using it right away, and let you know, my system processes a couple thousands purchases a day, so it's a fair trial.

@WhyNotHugo
Copy link
Member Author

Tests seem to still be failing on a bunch on combinations of Django + Python, so I'd hold testing it on a production environment for a bit.

@codecov
Copy link

codecov bot commented May 25, 2023

Codecov Report

Attention: 13 lines in your changes are missing coverage. Please review.

Comparison is base (84b52c9) 78.42% compared to head (2574ae3) 77.95%.

Files Patch % Lines
payments/cybersource/__init__.py 44.44% 3 Missing and 2 partials ⚠️
payments/models.py 50.00% 4 Missing ⚠️
payments/stripe/__init__.py 0.00% 3 Missing ⚠️
payments/paypal/__init__.py 88.88% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #306      +/-   ##
==========================================
- Coverage   78.42%   77.95%   -0.48%     
==========================================
  Files          29       29              
  Lines        1979     1964      -15     
  Branches      244      244              
==========================================
- Hits         1552     1531      -21     
- Misses        310      317       +7     
+ Partials      117      116       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@WhyNotHugo WhyNotHugo changed the title DRAFT: Use JSONField for BasePayment.attrs Use JSONField for BasePayment.attrs Oct 14, 2023
@WhyNotHugo WhyNotHugo marked this pull request as draft October 14, 2023 09:03
@WhyNotHugo
Copy link
Member Author

Looks like f4dfa5e is breaking some tests, but it's not clear to me why.

@WhyNotHugo
Copy link
Member Author

Split the first commit into #385

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants