non final capture + return amount + more documentation #148
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add final parameter for final captures. Defaults to true for old logic.
Changing it allows multiple captures.
First only paypal is supported but I have some providers in pipeline which use it too.
There is no check if captured_amount is bigger than total because some providers allow overcapture.
Secondly the amount or None is returned in refund and capture (BasePayment). This streamlines the return behaviour of Providers.
At last I add some documentation for the methods.