Add decimal formatting for durations #308
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmaupetit
reviewed
Sep 2, 2019
| @@ -84,11 +85,15 @@ def _style_short_id(id): | |||
| return fmt(element) | |||
|
|
|||
|
|
|||
| def format_timedelta(delta): | |||
| def format_timedelta(watson, delta): | |||
There was a problem hiding this comment.
This is breaking the API, what about the following instead?
Suggested change
| def format_timedelta(watson, delta): | |
| def format_timedelta(delta, as_decimal=False): |
There was a problem hiding this comment.
That's true. I can change it to the way you suggested. Would you prefer if I made this a file-local variable in cli.py or do the call in every method that uses format_timedelta?
There was a problem hiding this comment.
I would prefer not having a separated method to format timedelta but a single entrypoint that does the heavy lifting. This should be sufficient for such a small piece of code and its testability. WDYT @k4nar?
jmaupetit
reviewed
Sep 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I've added functionality that allows timedeltas to be formatted as a decimal number instead of hours, minutes and seconds.
This is useful for users that want to calculate a price based on an hourly rate. For example
watson aggreatenow shows4.50hif you've tracked 4 hours and 30 minutes.This feature is configurable via
watson config. You can also set the decimal precision used for formatting the numbers.I've also added documentation and tests for this feature.