Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR replaces manual socket creation with
socket.create_connection()
to support both IPv4 and IPv6 seamlessly, and updates thesplit_host_port()
to support IPv6 address.Motivation
IPv6 Support.
Previously, the code forced
AF_INET
for socket connections, making IPv6 usage either impossible or unreliable.For example, empty response from
client.stats()
.By switching to
socket.create_connection((self.host, self.port), self.socket_timeout)
, Python automatically selects the appropriate address family (IPv4 or IPv6).Testing
Using
docker-compose
.Make a memcached client container image.
Regression tests