Avoid urllib.parse.splitport DeprecationWarning
#257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andersk
force-pushed
the
splitport
branch
3 times, most recently
from
87a9696 to
d17964f
Compare
Signed-off-by: Anders Kaseorg <[email protected]>
“DeprecationWarning: urllib.parse.splitport() is deprecated as of 3.8, use urllib.parse.urlparse() instead” Signed-off-by: Anders Kaseorg <[email protected]>
jaysonsantos
requested changes
Oct 23, 2024
| @@ -17,7 +17,7 @@ jobs: | |||
| steps: | |||
| - uses: actions/checkout@v2 | |||
| - name: Set up Python ${{ matrix.python-version }} | |||
| uses: actions/setup-python@v2 | |||
| uses: LizardByte/setup-python[email protected] | |||
There was a problem hiding this comment.
Any specific reason on why this action is changing?
There was a problem hiding this comment.
CI doesn’t pass on master because Python 2.7 was removed from actions/setup-python last year: actions/setup-python#672.
If it were my project, I would have removed Python 2.7 support years ago—let me know if that’s the route you would prefer.
There was a problem hiding this comment.
Ok, I'll read the code on that to see what it does. The support for python 2 is there because on redhat there are still users using it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DeprecationWarning: urllib.parse.splitport() is deprecated as of 3.8, use urllib.parse.urlparse() instead