represent random.key_impl of builtin RNGs by canonical string name
#24593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We do not have great reason to return specs here, and sticking to strings instead can help with simple serialization.
jakevdp
requested changes
Oct 29, 2024
| @@ -296,11 +296,12 @@ def split(key: KeyArrayLike, num: int | tuple[int, ...] = 2) -> KeyArray: | |||
| def _key_impl(keys: KeyArray) -> PRNGImpl: | |||
There was a problem hiding this comment.
Suggested change
| def _key_impl(keys: KeyArray) -> PRNGImpl: | |
| def _key_impl(keys: KeyArray) -> str | PRNGSpec: |
| @@ -296,11 +296,12 @@ def split(key: KeyArrayLike, num: int | tuple[int, ...] = 2) -> KeyArray: | |||
| def _key_impl(keys: KeyArray) -> PRNGImpl: | |||
| assert jnp.issubdtype(keys.dtype, dtypes.prng_key) | |||
| keys_dtype = typing.cast(prng.KeyTy, keys.dtype) | |||
| return keys_dtype._impl | |||
| impl = keys_dtype._impl | |||
| return impl.name if impl.name in prng.prngs else PRNGSpec(impl) | |||
|
|
|||
| def key_impl(keys: KeyArrayLike) -> PRNGSpec: | |||
There was a problem hiding this comment.
Suggested change
| def key_impl(keys: KeyArrayLike) -> PRNGSpec: | |
| def key_impl(keys: KeyArrayLike) -> str | PRNGSpec: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No great reason to return specs here, and sticking to strings instead can help with simple serialization.