Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React other people messages and adding voice notes #42

Closed
wants to merge 1 commit into from

Conversation

Chelseasingla1
Copy link

@Chelseasingla1 Chelseasingla1 commented May 20, 2024

Title

React other people messages and adding voice notes

Description

I added a feature where one can react to other messages and give voice notes
#25 is still on ongoing need some changes in it.

Video link:
https://youtu.be/YYX7MOqyNw8

Screenshot 2024-05-20 203445

Here this recording option is there
And recording is on it is visible.
Screenshot 2024-05-20 203542

This R can be changes with an icon


Issue Ticket Number

Fixes #24


Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • I have followed the contributing guidelines of this project as mentioned in CONTRIBUTING
  • I have checked to ensure there aren't other open Pull Requests for the same update/change?
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes needed to the documentation

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to Our repository.🎊 Thank you so much for taking the time to point this out.

Copy link
Owner

@jatiinyadav jatiinyadav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Chelseasingla1,
Great work 🚀.

I would like to give few suggestions.

  • There should be Emoji when the user hovers on message and when the user will click on that emoji all the reactions should popup.
  • Please remove the R character on every message.

For the voice notes feature

  • When I click on the voice button it started recording, but neither I was able to send the audio or stop the recording.

Can you please look into this?

Thankyou.

@jatiinyadav
Copy link
Owner

Hi @Chelseasingla1,
Any updates?

@Chelseasingla1
Copy link
Author

Hi @Chelseasingla1, Any updates?

Hi i need some more time

Copy link

github-actions bot commented Jul 5, 2024

This issue has been automatically closed because it has been inactive for more than 30 days. If you believe this is still relevant, feel free to reopen it or create a new one. Thank you!

@github-actions github-actions bot closed this Jul 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Able to react to other people messages
2 participants