Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: landing page responsive, Removal of Inline css #38

Closed

Conversation

IP80808080
Copy link

@IP80808080 IP80808080 commented May 18, 2024

Title

Landing Page Responsive

Description

The landing page responsive for all the screen sizes.
The styling changes in styles/common.css
Removal of Inline CSS


Issue Ticket Number

Fixes #(15)


Type of change

  • [*] Bug fix (non-breaking change which fixes an issue)
  • [*] New feature (non-breaking change which adds functionality)
  • [*] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • [*] I have followed the contributing guidelines of this project as mentioned in CONTRIBUTING
  • *] I have checked to ensure there aren't other open Pull Requests for the same update/change?
  • [*] I have performed a self-review of my own code
  • [*] I have commented my code, particularly in hard-to-understand areas

@IP80808080
Copy link
Author

Sir I have Removed the previous pull request since there was some changes required, and submitted a pull request for issue #15, which includes a video explanation for better understanding. I kindly request you to review the pull request

Responsive.mp4

@jatiinyadav
Copy link
Owner

Hi @IP80808080,
Great work till now.

But I can see at 0:23, the background is still not responsive. You reloaded the page then it was working fine.
Please fix this.

@IP80808080
Copy link
Author

yes your right it was the problem with the canva I think, I will fix it

Copy link

This issue has been automatically closed because it has been inactive for more than 30 days. If you believe this is still relevant, feel free to reopen it or create a new one. Thank you!

@github-actions github-actions bot closed this Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants