Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: enable flags for NNN_PREVIEWIMGPROG #1990

Merged
merged 1 commit into from
Feb 3, 2025
Merged

fix: enable flags for NNN_PREVIEWIMGPROG #1990

merged 1 commit into from
Feb 3, 2025

Conversation

psicho2000
Copy link
Contributor

@psicho2000 psicho2000 commented Feb 2, 2025 •
edited
Loading

Following the comment, we wanted to be able to include command flags.

One use case could be using timg inside of a sixel-enabled tmux which needs the flag -ps:
export NNN_PREVIEWIMGPROG="timg -ps"

With the current solution, we would get:

preview-tui: row 456: timg -ps: Command not found.

This PR aims to fix that.

@jarun jarun merged commit 9a128f1 into jarun:master Feb 3, 2025
8 checks passed
@jarun
Copy link
Owner

jarun commented Feb 3, 2025

Thank you!

@psicho2000 psicho2000 deleted the fix/use-command-flags branch February 4, 2025 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@N-R-K N-R-K N-R-K approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@psicho2000 @jarun @N-R-K