Make using balance mode consistent with mask mode #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mask mode is toggled using an enable function and a disable function. Despite being a similar binary mode, balance mode is toggled using a single function that takes an argument specifying the status of the mode. No preference is expressed as to which API is better but since balance mode has only recently been added, this change makes balance mode match the approach taken by mask mode.
pyrmont
force-pushed
the
cleanup.balancemode-consistency
branch
from
507f42d
to
2e85007
Compare
|
@jart Not sure if this is a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mask mode is toggled using an enable function and a disable function. Despite being a similar binary mode, balance mode is toggled using a single function that takes an argument specifying the status of the mode. No preference is expressed as to which API is better but since balance mode has only recently been added, this change makes balance mode match the approach taken by mask mode.