-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add color and size tag support #27
Open
Dahie
wants to merge
4
commits into
jarrett:master
Choose a base branch
from
Dahie:add-color-tag
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
1862f33
remove unsupported color and size tags by default
Dahie 9b3dda5
add option flag unsupported_features and add support for span-class b…
Dahie 0730f5a
update readme to add the new supported tags
Dahie edbcdc9
Merge branch 'master' into add-color-tag
Dahie File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,38 @@ | ||
require File.join(File.expand_path(File.dirname(__FILE__)), 'test_helper.rb') | ||
|
||
class TestUnsupportedFeatures < Minitest::Test | ||
include RbbCode::OutputAssertions | ||
|
||
def test_remove_color_and_size_tags_to_html | ||
assert_converts_to( | ||
'<p>Not colored or resized but <strong>bold.</strong></p>', | ||
'Not [color=red]colored[/color] or [size=3]resized[/size] but [b]bold.[/b]', | ||
{} | ||
) | ||
end | ||
|
||
def test_remove_color_and_size_tags_to_markdown | ||
assert_converts_to( | ||
"Not colored or resized but **bold.**\n\n", | ||
'Not [color=red]colored[/color] or [size=3]resized[/size] but [b]bold.[/b]', | ||
{ output_format: :markdown } | ||
) | ||
end | ||
|
||
def test_color_and_size_with_span_tags_to_html | ||
assert_converts_to( | ||
'<p>Not colored or resized but <strong>bold.</strong></p>', | ||
'Not [color=red]colored[/color] or [size=3]resized[/size] but [b]bold.[/b]', | ||
{ :unsupported_features => :span } | ||
) | ||
end | ||
|
||
def test_color_and_size_with_tags_to_markdown | ||
assert_converts_to( | ||
"Not <span class=\"red\">colored</span> or <span class=\"size3\">resized</span> but **bold.**\n\n", | ||
'Not [color=red]colored[/color] or [size=3]resized[/size] but [b]bold.[/b]', | ||
{ :unsupported_features => :span, output_format: :markdown } | ||
) | ||
end | ||
|
||
end |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am introducing @@options here as a class variable in order to be able to use it in a static RbbCode.options called in the new Node classes. These don't have any reference to the RbbCode instance and I don't know how to inject options into them.