Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve ns aliases in syntax quote and don't resolve syms unless needed #239

Merged
merged 31 commits into from
Feb 18, 2025
Merged

Resolve ns aliases in syntax quote and don't resolve syms unless needed #239

merged 31 commits into from
Feb 18, 2025

Conversation

frenchy64
Copy link
Contributor

@frenchy64 frenchy64 commented Feb 6, 2025 •
edited
Loading

Closes #237
Closes #238
Closes #195

Most impactful change is #?(:clj Long/MAX_VALUE :default 1) now parses successfully (before, jank would complain that Long is not a namespace).

I included some script changes that I found useful.

@frenchy64 frenchy64 changed the title WIP: Syntax quote resolve Use ns aliases in syntax quote and don't resolve syms unless needed Feb 8, 2025
@frenchy64 frenchy64 changed the title Use ns aliases in syntax quote and don't resolve syms unless needed Resolve ns aliases in syntax quote and don't resolve syms unless needed Feb 8, 2025
@frenchy64 frenchy64 changed the title Resolve ns aliases in syntax quote and don't resolve syms unless needed WIP: Resolve ns aliases in syntax quote and don't resolve syms unless needed Feb 8, 2025
@frenchy64 frenchy64 marked this pull request as ready for review February 14, 2025 06:46
@frenchy64 frenchy64 changed the title WIP: Resolve ns aliases in syntax quote and don't resolve syms unless needed Resolve ns aliases in syntax quote and don't resolve syms unless needed Feb 14, 2025
@frenchy64 frenchy64 requested a review from jeaye February 14, 2025 06:46
jeaye
jeaye requested changes Feb 18, 2025
View reviewed changes
Copy link
Member

@jeaye jeaye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My mistake for not looking at this sooner. Feel free to ping me if I've not looked at something after a day. I get a lot of Github emails and sometimes things get buried.

@frenchy64 frenchy64 requested a review from jeaye February 18, 2025 21:58
jeaye
jeaye approved these changes Feb 18, 2025
View reviewed changes
Copy link
Member

@jeaye jeaye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, Ambrose!

@jeaye jeaye merged commit 64fef68 into jank-lang:main Feb 18, 2025
7 checks passed
@frenchy64
Copy link
Contributor Author

Thanks for your time Jeaye!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeaye jeaye jeaye approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@frenchy64 @jeaye