Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ViewModel Can be inject directly, without using ViewModelFactory #53

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

ViewModel Can be inject directly, without using ViewModelFactory #53

wants to merge 1 commit into from

Conversation

dalwadi2
Copy link

@dalwadi2 dalwadi2 commented Mar 9, 2019

ViewModel Can be inject directly, without using ViewModelFactory like Activity in Fragments and Dialog. Implement that in fragments and dialogs.

@dalwadi2
ViewModel Can be inject directly, without using ViewModelFactory like…
ead1d55 
… Activity in Fragments and Dialog. Implement that in fragments and dialogs.
@HuuNguyen312
Copy link

When ViewModel is injected directly, without using ViewModelFactory
-> Fragment ViewModel's onCleared not called

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dalwadi2 @HuuNguyen312