Optimize CI/CD pipeline architecture #433
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
Restructure GitHub Actions workflows to improve separation of concerns and maintainability: - Split CI and CD into separate workflows for better clarity and parallel execution - CI workflow now handles linting, testing, SonarQube analysis independently - CD workflow manages deployments with proper concurrency controls - Simplified cleanup, permanent preview, and production workflows - Updated to use github-ci v2.5 for consistency - Removed redundant workflow files (clean_on_delete, clean_on_dispatch, preview_on_dispatch) - Standardized app naming to flask-react-template across all workflows
- Update README to reference CI/CD instead of Deployment - Update workflow badge to use new production.yml filename - Add comprehensive CI/CD pipeline documentation with Mermaid diagram - Document independent CI and CD workflows - Clarify workflow responsibilities and timing estimates - Update deployment workflows list to match new structure
jjalan
force-pushed
the
optimize-ci-pipeline
branch
from
6e79486 to
3495cf9
Compare
This comment has been minimized.
This comment has been minimized.
Flask-react-template requires both Node.js and Python dependencies for linting. Added Python 3.11 setup and pipenv installation to the lint job.
This comment has been minimized.
This comment has been minimized.
Flask-react-template requires v3.2.5 reusable workflows which properly handle: - Temporal worker hostname configuration - Multi-host ingress setup - Build args and deployment parameters The v2.5 individual action approach from node-react-template doesn't support flask-react-template's specific infrastructure requirements.
This comment has been minimized.
This comment has been minimized.
…ean check names Changed from reusable workflows (which show nested job names like deploy/build, deploy/deploy) to single-job workflows using v3.2.5 individual build and deploy actions. This provides clean check names matching node-react-template: - ci/lint - ci/sonarqube - ci/review - ci/test - cd/deploy (single check instead of nested)
Analysis Details0 Issues
Coverage and Duplications
Project ID: jalantechnologies_flask-react-template |
Minimum allowed line rate is |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Restructure GitHub Actions workflows to align with the optimized CI/CD architecture from node-react-template.
Changes
Technical Details
The new structure provides: