[1483] Remove the signature test generate module and migrate to the s… #1995
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamezp
force-pushed
the
update-siganture-tests
branch
from
d4ff448 to
880206b
Compare
scottmarlow
reviewed
Feb 26, 2025
| jakarta.security.auth.message=3.1 | ||
| jakarta.security.enterprise=4.0 | ||
| jakarta.security.jacc=3.0 | ||
| jakarta.servlet.jsp.jstl=4.0 |
There was a problem hiding this comment.
I think jstl is 3.0 https://jakarta.ee/specifications/tags/
There was a problem hiding this comment.
Oops, yes good catch.
…ignaturevalidation module generating the signature files. Other updates to get the signature tests running. Signed-off-by: James R. Perkins <[email protected]>
jamezp
force-pushed
the
update-siganture-tests
branch
from
880206b to
619e315
Compare
scottmarlow
approved these changes
Feb 26, 2025
|
Thanks for the excellent changes James! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…evalidation module generating the signature files.
Other updates to get the signature tests running.
Fixes Issue
resolves #1483
Describe the change
This removes the
generatemaven module in favor of generating the files in the signaturevalidation module. There were a couple missing files.One change to note is the removal of requiring the version number to the suffix for the signature test files. There seems to be no real value in that.
Additional context
I will follow up with some instructions on how to create the runner.
CC @alwin-joseph @anajosep @arjantijms @cesarhernandezgt @dblevins @m0mus @edbratt @gurunrao @jansupol @jgallimore @kazumura @kwsutter @LanceAndersen @bhatpmk @RohitKumarJain @shighbar @gthoman @brideck @OndroMih @dmatej
@starksm64 @scottmarlow