Support minimum JDK of 11+ and minimum of Android API 33+ #709 #714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jorge Bescos Gascon <[email protected]>
lukasj
reviewed
Feb 29, 2024
api/pom.xml
Outdated
| @@ -379,7 +365,7 @@ | |||
| osgi.serviceloader;filter:="(osgi.serviceloader=jakarta.mail.util.StreamProvider)"; | |||
| osgi.serviceloader="jakarta.mail.util.StreamProvider"; | |||
| cardinality:=multiple;resolution:=optional, | |||
| osgi.ee;filter:="(&(osgi.ee=JavaSE)(version=1.8))" | |||
| osgi.ee;filter:="(&(osgi.ee=JavaSE)(version=11))" | |||
There was a problem hiding this comment.
this line can be removed (used to be a workaround)
lukasj
reviewed
Feb 29, 2024
api/pom.xml
Outdated
| @@ -323,27 +323,13 @@ | |||
| <groupId>org.apache.maven.plugins</groupId> | |||
| <artifactId>maven-compiler-plugin</artifactId> | |||
| <configuration> | |||
| <release>9</release> | |||
| <release>11</release> | |||
There was a problem hiding this comment.
define maven.compiler.release and maven.compiler.testRelease properties and remove this line (and the one for javadoc) instead
Signed-off-by: Jorge Bescos Gascon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#709
I set it as a draft for now, as we have to wait for branch 2.2.x and I will need to check also some documents.