Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix typo indicated in #234 #295

Merged
merged 4 commits into from
Feb 18, 2024
Merged

Conversation

antoniosanct
Copy link
Contributor

@lukasj
I wish this PR would be useful for the project.

Regards,
Antonio.

Signed-off-by: Antonio Santos Izaguirre <[email protected]>
@@ -144,7 +144,7 @@
* that doesn't have {@link XmlRootElement}. But they can't show up in an
* XML instance (because they don't have XML element names).
*
* <p><b>Example 2: XML Schema Susbstitution group support</b>
* <p><b>Example 2: XML Schema substitution group support</b>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

first letter should be kept in upper case

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed. However, At first commit I copied same format than line 37. Check it out and say to me if it is necessary to fix too.

Regards,
Antonio.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the best would be to bring in consistency accross all usages ;-)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in XmlElementDecl too!

Signed-off-by: Antonio Santos Izaguirre <[email protected]>
@lukasj lukasj self-requested a review February 18, 2024 00:32
@lukasj
Copy link
Contributor

lukasj commented Feb 18, 2024

btw: same/similar typos are there in XmlElementDecl - can you fix it all at once?

@lukasj lukasj linked an issue Feb 18, 2024 that may be closed by this pull request
@lukasj lukasj merged commit 8e787dc into jakartaee:master Feb 18, 2024
2 of 3 checks passed
@antoniosanct antoniosanct deleted the jaxb-api-234 branch February 18, 2024 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Typo in Example 2 heading in javax.xml.bind.annotation API
2 participants