Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add exclusions support to cli #1581

Draft
wants to merge 11 commits into
base: master
Choose a base branch
from
Draft

Add exclusions support to cli #1581

wants to merge 11 commits into from

Conversation

Stark-X
Copy link

@Stark-X Stark-X commented Feb 20, 2024

Add arg --exclusions to jacoco cli

@Stark-X
Copy link
Author

Stark-X commented Feb 20, 2024

[ERROR] Failed to execute goal org.apache.maven.plugins:maven-enforcer-plugin:3.3.0:enforce (enforce-distribution-size) on project jacoco:
[ERROR] Rule 0: org.apache.maven.enforcer.rules.files.RequireFilesSize failed with message:
[ERROR] /home/vsts/work/1/s/jacoco/target/jacoco-0.8.12.202402201145.zip size (4608852) too large. Max. is 4600000/home/vsts/work/1/s/jacoco/target/jacoco-0.8.12.202402201145.zip
[ERROR] -> [Help 1]

Above is the error from JDK9 pipeline, how could I sovle ?

@marchof
Copy link
Member

marchof commented Feb 20, 2024

@Stark-X We have a sanity check in our build for the size of the zip with all artifacts:

https://github.com/jacoco/jacoco/blob/master/jacoco/pom.xml#L114

You may increase the upper limit.

org.jacoco.core/pom.xml Outdated Show resolved Hide resolved
@@ -30,6 +30,11 @@
<groupId>${project.groupId}</groupId>
<artifactId>org.jacoco.core</artifactId>
</dependency>
<dependency>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really, we don't want to have that dependency outside the Maven plugin. Why should any user of our library get an dependeny on the Maven framework?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the exiting filtering in core we use our own class WildcardMatcher, maybe this works here.

@Godin Godin marked this pull request as draft February 24, 2024 00:34
@Stark-X
Copy link
Author

Stark-X commented Feb 24, 2024

before jdk 7, the java.nio does not exists, any suggestion?

Copy link

@barnett-yuxiang barnett-yuxiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test code?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants