A little enhancement of report

[the-end-sea-of-the-world]

Deal with issue #1100. Check the parent file of csv and xml, create if it does not exist.

[marchof]

Hi @the-end-sea-of-the-world, welcome to the JaCoCo project and thanks for your contribution!

We try to provide a regression test for every feature. What about adding (or extending) the existing tests to validate your code?

Also your implementation will not work on Unix/Linux system where the path separator is a forward slash /.

Instead of parsing Strings the java.io.File API allows to determine the parent folder. We already use this in our code base, for example here.

[marchof]

• Add unit test
• Use java.io.File API to also support Unix path separators

[the-end-sea-of-the-world]

Thanks for your suggestion, I will try to modify it.

[the-end-sea-of-the-world]

Hello, I have changed the code to use java.io.File API and added JUnit tests and a Maven project demo used in the test to generate a report.

[marchof]

@the-end-sea-of-the-world thanks for the update!

To be honest I don't think we will maintain the demo code in the JaCoCo project. May I ask you to remove it?

[marchof]

The exitsting ReportTest is the better place to test the Report class.

[marchof]

Please extract a private method createParent() to avoid code duplication.

[marchof]

Also as you can see here the build fails as the source code has some formatting issues. Our development setup with Eclipse auto-formatting is described here.

[the-end-sea-of-the-world]

Thanks for your advice. There are a lot of things in school these days. I will modify the code on the weekend.

[the-end-sea-of-the-world]

@marchof all the problems have been solved. Is there any other one?